Skip to content

feat!: disable parsing require alias by default#12697

Merged
LingyuCoder merged 3 commits intov2from
feat/disable-parsing-require-alias
Jan 12, 2026
Merged

feat!: disable parsing require alias by default#12697
LingyuCoder merged 3 commits intov2from
feat/disable-parsing-require-alias

Conversation

@LingyuCoder
Copy link
Contributor

@LingyuCoder LingyuCoder commented Jan 12, 2026

Summary

  • Disable parsing require alias (var myRequire = require; require("./xxx")) by default

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@LingyuCoder LingyuCoder requested a review from hardfist as a code owner January 12, 2026 03:05
@LingyuCoder LingyuCoder force-pushed the feat/disable-parsing-require-alias branch from b7dea12 to fc8eb39 Compare January 12, 2026 03:06
@netlify
Copy link

netlify bot commented Jan 12, 2026 •
edited
Loading

✅ Deploy Preview for rspack-v2 canceled.

Name Link
🔨 Latest commit 6a27897
🔍 Latest deploy log https://app.netlify.com/projects/rspack-v2/deploys/6964661081ce770008f115ac

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jan 12, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2026

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 3 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB -8.0 B (-0.0%)
react-1k 825.4 KB 0
react-5k 2.7 MB +1.0 B (0.0%)
rome 986.0 KB +1.7 KB (0.2%)
ui-components 2.1 MB 0
📋 Detailed Reports (Click to expand)

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

📌 Baseline Commit: a4152c52d2 | PR: #12694

Metric Current Baseline Change
📊 Total Size 5.7 MB 5.7 MB -8.0 B (-0.0%)
📄 JavaScript 5.7 MB 5.7 MB -8.0 B (-0.0%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-10k Bundle Diff

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

📌 Baseline Commit: a4152c52d2 | PR: #12694

Metric Current Baseline Change
📊 Total Size 2.7 MB 2.7 MB +1.0 B (0.0%)
📄 JavaScript 2.7 MB 2.7 MB +1.0 B (0.0%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-5k Bundle Diff

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

📌 Baseline Commit: a4152c52d2 | PR: #12694

Metric Current Baseline Change
📊 Total Size 986.0 KB 984.3 KB +1.7 KB (0.2%)
📄 JavaScript 986.0 KB 984.3 KB +1.7 KB (0.2%)
🎨 CSS 0 B 0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: rome Bundle Diff

Generated by Rsdoctor GitHub Action

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label Jan 12, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2026

📦 Binary Size-limit

Comparing 6a27897 to fix(test): flaky test due to calling toJSON while hot updating (#12694) by pshu

🎉 Size decreased by 358.13KB from 47.88MB to 47.53MB (⬇️0.73%)

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 12, 2026

Merging this PR will not alter performance

✅ 16 untouched benchmarks
⏩ 1 skipped benchmark1

Comparing feat/disable-parsing-require-alias (6a27897) with v2 (50af856)

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

@LingyuCoder LingyuCoder added the release: breaking change release: breaking change related release(mr only) label Jan 12, 2026
@LingyuCoder LingyuCoder merged commit 57a28c1 into v2 Jan 12, 2026
53 checks passed
@LingyuCoder LingyuCoder deleted the feat/disable-parsing-require-alias branch January 12, 2026 03:53
LingyuCoder added a commit that referenced this pull request Jan 14, 2026
@LingyuCoder
feat!: disable parsing require alias by default (#12697)
0270dde 
* feat: disable parsing require alias by defualt

* feat: disable parsing require alias by defualt

* feat: disable parsing require alias by defualt
hardfist pushed a commit that referenced this pull request Jan 14, 2026
@LingyuCoder @hardfist
feat!: disable parsing require alias by default (#12697)
04f1008 
* feat: disable parsing require alias by defualt

* feat: disable parsing require alias by defualt

* feat: disable parsing require alias by defualt
LingyuCoder added a commit that referenced this pull request Jan 15, 2026
@LingyuCoder
feat!: disable parsing require alias by default (#12697)
309a75a 
* feat: disable parsing require alias by defualt

* feat: disable parsing require alias by defualt

* feat: disable parsing require alias by defualt
@chenjiahan chenjiahan mentioned this pull request Jan 18, 2026
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hardfist hardfist hardfist approved these changes

Assignees

No one assigned

Labels

release: breaking change release: breaking change related release(mr only) release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LingyuCoder @hardfist